As for the determination condition of resync in y-websocket library

jarone · May 7, 2022, 6:14am

yjs/y-websocket/blob/f133fb2db5e4867f1ea7ff8166a0687fd1676fdd/src/y-websocket.js#L241

      
        
             * @type {boolean}
             */
            this.shouldConnect = connect
            
            
/**
             * @type {number}
             */
            this._resyncInterval = 0
            if (resyncInterval > 0) {
              this._resyncInterval = /** @type {any} */ (setInterval(() => {
                if (this.ws) {
                  // resend sync step 1
                  const encoder = encoding.createEncoder()
                  encoding.writeVarUint(encoder, messageSync)
                  syncProtocol.writeSyncStep1(encoder, doc)
                  this.ws.send(encoding.toUint8Array(encoder))
                }
              }, resyncInterval))
            }
            
            
/**

Is it more appropriate to execute resync when the WS instance object exists and the connection state is OPEN?

For example:

if (this.ws && this.ws.readyState === WebSocket.OPEN)

dmonad · May 10, 2022, 12:47pm

Yes, that would be more accurate. it probably doesn’t make a difference in practice. However, would be happy to accept a PR!

jarone · June 26, 2022, 3:56pm

Hi, @dmonad

Here it is: