YJS update not happening on marks on images

jibin2706 · July 31, 2023, 5:46am

Links on images not updating

opened 02:38PM - 17 Jul 23 UTC

bug

**Checklist** * [x] Are you reporting a bug? Use github issues for bug report…s and feature requests. For general questions, please use https://discuss.yjs.dev/ * [x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/ **Describe the bug** Marks on images are not getting updated from one document to other **To Reproduce** Steps to reproduce the behavior: 1. Go to the demo example of 'https://docs.yjs.dev/ecosystem/editor-bindings/prosemirror' 2. Click on Insert Image > Add an image 3. Click on the image & Click on add or remove link icon and add any link to that image 4. Inspect the image element, link is added on the first instance 5. Now inspect the image on other instance, changes are not updated **Expected behavior** The link should have been updated on both the editor instance. **Screenshots** If applicable, add screenshots to help explain your problem. **Environment Information** - Chrome **Additional context** Found this issue on Remirror which uses this library, so tried to reproduce the same. https://github.com/remirror/remirror/issues/2122

TeemuKoivisto · August 2, 2023, 1:32pm

It’s a known issue Yjs doesn’t persist marks on nodes which ProseMirror allows you to do. Safest bet at the moment is to use attributes instead.

jibin2706 · August 3, 2023, 5:56am

@TeemuKoivisto Can you elaborate more on this, or point me to an existing issue?

TeemuKoivisto · August 3, 2023, 7:02am

github.com/yjs/y-prosemirror

Does not support marks on non-TextNodes

opened 09:05PM - 03 May 21 UTC

ascott18

bug

**Checklist** * [x] Are you reporting a bug? Use github issues for bug report…s and feature requests. For general questions, please use https://discuss.yjs.dev/ * [x] Try to report your issue in the correct repository. Yjs consists of many modules. When in doubt, report it to https://github.com/yjs/yjs/issues/ **Describe the bug** This plugin fundamentally does not support marks on nodes that are not text nodes. For example, Tiptap's image node, which is an inline, non-text node: https://github.com/ueberdosis/tiptap/blob/v1/packages/tiptap-extensions/src/nodes/Image.js. **To Reproduce** 1. Apply a mark to an inline node. For example, apply a hyperlink (https://github.com/ueberdosis/tiptap/blob/v1/packages/tiptap-extensions/src/marks/Link.js) to an image (https://github.com/ueberdosis/tiptap/blob/v1/packages/tiptap-extensions/src/nodes/Image.js) 2. Be the editor of the document. Observe that the JSON version of the prosemirror doc does contain the expected mark, and that the HTML is rendered with the correct `<a></a>` wrapping the image node. 2. Be a realtime collaborator on the same document, OR reload the document using the serialized ydoc. Observe that the hyperlink on the image is missing because the mark is not serialized into the ydoc. **Expected behavior** Marks on custom nodes are handled just as attributes on custom nodes are handled.

jibin2706 · August 3, 2023, 1:36pm

thanks @TeemuKoivisto, this is very helpful